Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT menu development for 13_3_X (1/N) #43789

Merged
merged 2 commits into from
Jan 31, 2024
Merged

HLT menu development for 13_3_X (1/N) #43789

merged 2 commits into from
Jan 31, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 25, 2024

backport of #43788

PR description:

Development of HLT menus for CMSSW_13_3_X:

  • this is an intermediate update towards the 2024 proton-proton run data-taking

This update includes the integration of the following JIRA tickets:

  • CMSHLT-2975 [EXO,TSG]: Bug in configuration of *...NoFiltersNoVertex...* HLT/MC paths
  • CMSHLT-2982 [EXO,TSG]: Misconfiguration of hltL3fL1DoubleMuf0L2NVf15f7L3SingleMuNVf18DisplacedHybDxy0p1cm
  • CMSHLT-2979 [EXO,HIG,TSG]: Misconfiguration of hltDiPFJet45MJJ1050 (VBF-parking triggers)
  • CMSHLT-2985 [EXO,TSG]: Set hltStoppedHSCPIterativeCone4CaloJets.srcPVs to empty InputTag
  • CMSHLT-2986 [MUO,TSG]: Remove refs to offline products in MuonIdProducer instances at HLT

In addition it integrates in the combined table "Special" FOG trigger paths for non-physics production menus and updates table and testing scripts accordigly.
This addresses the following JIRA tickets:

  • CMSHLT-2860 [TSG]: The FOG "Ubermenu" (merge of FOG's "special" menus)
  • CMSHLT-2972 [TSG]: Circulating, Cosmics, CRUZET, MWGR -- port to 13_3_X

PR validation:

TSG integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43788 to CMSSW_13_3_X to address FOG data-taking needs for early 2024 data-taking.

@mmusich
HLT menu development for 13_3_X (branch 13_3_X)
77c6fb1 
This is an intermediate update towards the 2024 proton-proton run data-taking.
This update includes the integration of the following JIRA tickets:
- [CMSHLT-2975](https://its.cern.ch/jira/browse/CMSHLT-2975) [EXO,TSG]: Bug in configuration of *...NoFiltersNoVertex...* HLT/MC paths
- [CMSHLT-2982](https://its.cern.ch/jira/browse/CMSHLT-2982) [EXO,TSG]: Misconfiguration of hltL3fL1DoubleMuf0L2NVf15f7L3SingleMuNVf18DisplacedHybDxy0p1cm
- [CMSHLT-2979](https://its.cern.ch/jira/browse/CMSHLT-2979) [EXO,HIG,TSG]: Misconfiguration of hltDiPFJet45MJJ1050 (VBF-parking triggers)
- [CMSHLT-2985](https://its.cern.ch/jira/browse/CMSHLT-2985) [EXO,TSG]: Set hltStoppedHSCPIterativeCone4CaloJets.srcPVs to empty InputTag
- [CMSHLT-2986](https://its.cern.ch/jira/browse/CMSHLT-2986) [MUO,TSG]: Remove refs to offline products in MuonIdProducer instances at HLT
@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Jan 25, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2024 •
edited
Loading

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @missirol, @silviodonato, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2024 •
edited
Loading

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jan 25, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Jan 25, 2024

enable gpu

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3048ca/37046/summary.html
COMMIT: 9f8c2bb
CMSSW: CMSSW_13_3_X_2024-01-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43789/37046/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

@Martin-Grunewald
Copy link
Contributor

please test

@mmusich
Integrate "Special" FOG trigger paths for non-physics production menu…
0c199eb 
…, update table and testing scripts

This update includes the integration of the following JIRA tickets:
- [CMSHLT-2860](https://its.cern.ch/jira/browse/CMSHLT-2860) [TSG]: The FOG "Ubermenu" (merge of FOG's "special" menus)
- [CMSHLT-2972](https://its.cern.ch/jira/browse/CMSHLT-2972) [TSG]: Circulating, Cosmics, CRUZET, MWGR -- port to 13_3_X
@mmusich mmusich force-pushed the HLTdevelopment133X branch from 9f8c2bb to 0c199eb Compare January 26, 2024 09:02
@cmsbuild
Copy link
Contributor

Pull request #43789 was updated. @cmsbuild, @Martin-Grunewald, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jan 26, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3048ca/37064/summary.html
COMMIT: 0c199eb
CMSSW: CMSSW_13_3_X_2024-01-25-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43789/37064/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1338
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4b1d6d3 into cms-sw:CMSSW_13_3_X Jan 31, 2024
13 checks passed
@mmusich mmusich deleted the HLTdevelopment133X branch January 31, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
4 participants
@mmusich @cmsbuild @Martin-Grunewald @rappoccio